ENH: Add layout_mode_font_height_weight argument to PageObject.extract_text()
#2920
+95
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
+ Coverage 96.36% 96.39% +0.02%
==========================================
Files 52 52
Lines 8728 8728
Branches 1589 1589
==========================================
+ Hits 8411 8413 +2
+ Misses 187 186 -1
+ Partials 130 129 -1 ☔ View full report in Codecov by Sentry. |
hpierre001
force-pushed
the
issue-2915
branch
2 times, most recently
from
22c82e2
to
8aef4ec
Compare
tests/test_text_extraction.py
Outdated
|
|
||
| def test_layout_mode_vertical_space(): | ||
| """Tests for #2915""" | ||
| reader = PdfReader(RESOURCE_ROOT / "attachment.pdf") |
There was a problem hiding this comment.
I would recommend using crazyones.pdf instead which should have the same content.
Apart from this: Could you please extend the test to actually show the difference between different weights? By just looking at the existing test, it is not really clear to me where the actual difference is (unless looking at others tests or crazyones.txt).
hpierre001
force-pushed
the
issue-2915
branch
from
8aef4ec
to
c3dae7b
Compare
…extract_text()``
…extract_text()``
hpierre001
force-pushed
the
issue-2915
branch
from
c3dae7b
to
df76211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature proposed in issue #2915